investigate: fix flaky picker tests racing on global override
main·
Commit

TestRunInvestigateConfigPicker_FiltersNonInstalled and TestRunInvestigateConfigPicker_QuorumExceedsAgents both installed a process-global picker-form override via SetPickerFormFnForTest while calling t.Parallel(). The atomic.Pointer prevents a data race but not the logical clobber: one test's override could replace the other's mid-run, so QuorumExceedsAgents would read the sibling's quorum=0 override and see no error — the exact flake seen in test-core. picker.go already documents that conflicting-override tests must not run in parallel. Drop t.Parallel() from both.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com Entire-Checkpoint: 01KX31J6HQTY4XX27QGH64PW1G
Checkpoints
Checkpoint 1