inspect: add output destination (local or post to trail finding)

main

Commit

dipree2mo ago

Profiles can now choose where the final verdict is delivered:

  • local (default): printed + saved to the local review manifest.
  • trail: additionally posted to the branch's trail as a finding via the data API (entire trail finding).

Wiring:

  • settings: new ReviewProfileConfig.Output ("output", omitempty).
  • review: ReviewOutputLocal/Trail consts, profileOutput resolver, normalizeReviewOutput validation.
  • guided setup: promptForOutputMode step after the judge pick.
  • scripted: --set-output local|trail (validated).
  • --list / discovery catalog show the destination.
  • runtime: runReview resolves the mode and both run paths call maybePostReviewToTrail after writing the local manifest; for trail it invokes the injected Deps.PostReviewToTrail hook, implemented in review_bridge.go via resolveTrailReviewTarget + createTrailReviewFinding. Single-inspector runs (no synthesized verdict) post the combined inspector narratives. Posting never fails the run; a nil hook or error degrades to a notice.

Tests for profileOutput + scripted --set-output (valid/invalid/local). Docs updated.

Entire-Checkpoint: 54a857d99cf5

Checkpoints

Checkout the hand off doc that I just added.

PiOpus 4.8
View session
Checkpoint 1