Review Claude Code Background Subagents Checkpoints

Pi·GPT-6-astra·Soph·3d ago·1hr 8min·1 Checkpoint·14 file changes·+567/-119·44.6K tokens

can you review the changes

3d ago·5.4s

I’ll review the uncommitted changes, trace the lifecycle behavior, and check for regressions and test gaps.

Found two issues:

  • P2 — Resumed subagents can match an old completed record. state.go:689 returns the first matching AgentID. Resuming a Claude subagent reuses its agent ID with a new tool-use ID. If the earlier completed record hasn’t been condensed, the stop handler selects it and skips completion of the new task. Prefer the live matching record and add a resume regression test.

  • P2 — Malformed tool input is logged verbatim. hooks.go:98–99 logs arbitrary run_in_background content without redaction. An unexpected string/object could contain sensitive model-provided content. Log only the invalid type or a generic warning.

Targeted unit and integration tests passed. No files changed.

can you review again

3d ago·6.6s

I’ll verify the two fixes and recheck the surrounding lifecycle paths for regressions.

Both previous findings are fixed, with regression tests covering them. I found no additional actionable issues.

Targeted unit and integration tests passed; git diff --check is clean. Full CI and lint were not run.