Pin Git Background GC Off in Test Environment

Claude Code·Opus 4.8[1m]·toothbrush·3mo ago·3min·1 Checkpoint·1 file change·+15/-4·11K tokens

please open a PR for COR-394

3mo ago·2m

Passes 50x. Now run fmt, lint, and the broader strategy test suite to ensure no regression:

commit and push, CI will run test.

3mo ago·1m

PR opened: https://github.com/entireio/cli/pull/1378

What it does: Pins git background gc/maintenance off in the isolated test env (GitIsolatedEnv/IsolateGitConfigEnv), so a detached git gc can't outlive a test holding .git/objects open and race t.TempDir() cleanup.

  • Central fix — applied via the shared isolation config file, so every git-shelling strategy test benefits, not just the one flaking.
  • Verified locally: go test -run TestSafelyAdvanceLocalRef -count=50 -p 4 → green.
  • Tradeoff: didn't run mise run lint/test:ci locally (you interrupted to push) — CI will catch fmt/lint. The change is a small string write in one helper, low risk.
72ac486test: pin git background gc off in isolated test env (COR-394) GitIsolatedEnv/IsolateGitConfigEnv now point git at a config that disables gc.auto, gc.autoDetach, maintenance.auto, and fetch.writeCommitGraph. A detached `git gc`/`git maintenance` process could outlive a test while still holding .git/objects open, racing t.TempDir()'s deferred RemoveAll and failing with "directory not empty". Fixes flaky TestSafelyAdvanceLocalRef_DoesNotReplayDisconnectedChainWhenTargetIsShallow; applied centrally so other git-shelling strategy tests don't regress. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: c57ad18d4e04+15/-4