Improve Timeout Configuration Clarity

Claude Code·Opus 4.8[1m]·toothbrush·3mo ago·4min·3 Checkpoints·3 file changes·+6/-5·35.2K tokens

i opened a PR and there are some comments. take a look for me. https://github.com/entireio/cli/pull/1487

3mo ago·51.8s

All three Copilot comments addressed and verified (lint clean, tests pass).

Fixes:

  • transport.go — invalid-env warning now names the effective defaults: using defaults (4s failover, 10s discovery), so it's actionable when debugging slow-link timeouts.
  • git-remote-entire/main.go — comment now references DiscoveryDialTimeout (the actual call) and notes ENTIRE_CONNECT_TIMEOUT_SECONDS can override it, instead of misleadingly citing the constant.
  • transport_test.go — renamed "unset …" cases to "blank …" (both DialTimeout and DiscoveryDialTimeout), since t.Setenv(..., "") sets blank, not unset.

Want me to commit these? (Not pushing — your call.)

commit separately.

3mo ago·24.9s

Three separate commits, one per comment. Not pushed.

ce0c3eeName effective defaults in invalid-timeout warning Discovery and failover defaults differ, so "using defaults" alone was not actionable when debugging slow-link timeouts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: be0e1af46fff+1/-1
b6f55d4Fix misleading discovery-dial-budget comment The client uses DiscoveryDialTimeout(), which ENTIRE_CONNECT_TIMEOUT_SECONDS can override, not the DefaultDiscoveryDialTimeout constant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 4cf6f00c27b3+3/-2
9cdac4eRename "unset" timeout test cases to "blank" t.Setenv with "" sets a blank value, not an unset one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 192662c5733c+2/-2