Address PR Comments and Feedback

Claude Code·Opus 4.8[1m]·Soph·3mo ago·24min·1 Checkpoint·1 file change·+5/-6·10.6K tokens

can you take a look at the comments of https://github.com/entireio/cli/pull/1543

3mo ago·31.3s

Two bot review comments, both on mise-tasks/dev/publish. Here's the rundown:

1. Cursor Bugbot — "Tilde not expanded in target" (Medium)

If a target like ~/go/bin reaches the script as a literal string, line 9 (mkdir -p "$target") and line 11 (cd "$target") won't expand the ~, so it'd create a literal ~/go/bin dir under CWD.

My take: largely a false positive for the normal path. When you run mise run dev:publish ~/go/bin at a shell, the shell expands ~ before the script sees it, so $1 is already absolute. It only bites if someone quotes it ('~/go/bin') or passes it through usage_target as a literal tilde. Low real-world risk, but trivially defensible.

2. Copilot — "Pre-set relative GOBIN passed through unchanged"

The comment on line 11 says go install requires an absolute GOBIN, but you only normalize to absolute when target is given. If a user already has GOBIN=bin (relative) in their env, line 13 now passes it through unchanged and go install fails — whereas the old code always overrode GOBIN with the absolute ${GOPATH:-$HOME/go}/bin.

My take: valid edge case, niche. It's a behavior change (old code ignored any pre-set GOBIN; new code honors it), so a pre-existing relative GOBIN would newly break.


Both are minor and dev-only (this is just an install helper). Want me to address them? A small fix covers both — normalize whatever GOBIN ends up being to an absolute path after line 13:

This makes one cd && pwd normalize the final path (covering the relative-GOBIN case) — though note it still won't expand a literal quoted ~, since that's a shell-expansion concern, not the script's. Let me know if you'd like me to apply it or just reply to the bots.

yes, do your suggestion

3mo ago·2m

Applied and verified (bash -n syntax OK, shellcheck clean).

What changed:

  • A single cd && pwd now normalizes the final GOBIN to absolute, whether it came from target, a pre-set GOBIN, or the ~/go/bin default — this covers Copilot's relative-GOBIN concern.
  • Split the assignment from export to satisfy shellcheck SC2155 (so a failing cd isn't masked).

Note on the Cursor tilde comment: as discussed, a literal quoted ~ still won't expand — that's shell behavior, not the script's job — but the normal mise run dev:publish ~/go/bin invocation works fine since the shell expands ~ before the script runs.

Want me to commit this, or reply to the bots on the PR?