Fix Git Remote Helper Status Relay
COmmit the staged changes. This enables showing the actual info coming from the server:
Branch protection violation ! [remote rejected] branch-test -> branch-test (upstream: push declined due to repository rule violations) error: failed to push some refs to 'X'
Invalid ref: ! [remote rejected] test-prefix -> test-prefix (ref name conflicts with an existing ref namespace) error: failed to push some refs to 'X'
Now for perms: ! [remote rejected] new-test/repo -> new-test/repo (pushing to GitHub: tracing transport: handshake: http transport: authorization failed: unexpected requesting "https://github.com/x/x/info/refs?service=git-receive-pack" status code: 403: Permission to x/x.git denied to <user>.) error: failed to push some refs to 'X'
Add those examples on the commit message.
Here's the draft commit. Please confirm before I run it.
Files to stage:
internal/remotehelper/githelper/push.go
Draft message:
Shall I proceed?
yep
Committed as ad52a591c on helper-status.
This control-flow change is important user-facing behavior, but there’s no regression test covering handlePush output when send-pack exits non-zero (per-ref rejection). Given the amount of existing protocol-level test coverage in this package, please add a unit test that simulates a failing git send-pack --helper-status and asserts that the helper-status lines are still written to stdout before handlePush returns an error (e.g., by placing a stub git executable early in PATH that emits the expected pktline + helper-status and exits 1).
Here's the draft commit. Please confirm.
File: internal/remotehelper/githelper/invariants_test.go
Draft message:
Shall I commit?
yep
GPG agent refused — likely needs unlocking. The commit did not happen (no --amend risk). Please unlock your GPG agent and let me know to retry, or run it yourself.
try again
Committed as 052ba33ae. Branch is one commit ahead of origin/helper-status.