Replace Internal 'Core' Term With 'Login Server'
my colleague pointed out a good point:
nit: I wouldn't mention "core" to a message to the user.
we should talk about the "login server" anywhere we are saying "core" to a user. check over the PR thoroughly.
Done. Branch is clean on origin/main and ready to push.
What changed — removed every user-facing "core" in the PR, replaced with "login server":
auth_context.go— contexts-table column headerCORE URL→LOGIN SERVER(+ test assertion)logout.go—--everywhere/--all-contextshelp text: "active core" → "active login server", "context's core" → "context's login server"logout.go+auth.go— TLS-check error"context core URL check"→"context login server URL check"(surfaces to users via main.go)
Left alone (kept "core"): code comments, internal identifiers (coreURL, CoreURL, coreAuthSessionsPath), test helpers — none reach the user.
Heads up — two pre-existing user-facing "core" strings outside this PR's diff, so I didn't touch them to keep scope tight:
cmd/entire/cli/auth/repo_token.go:68— "...set ENTIRE_AUTH_BASE_URL to a core that exposes /oauth/token"cmd/git-remote-entire/main.go:247— "is not a trusted core for cluster"
Say the word if you want those folded in too.
Status: committed (0caa415ae8), rebased cleanly onto origin/main (20 commits, no conflicts), build + auth/logout/context tests pass. Not pushed — yours to push.
let's fix these two while we're at it:
- cmd/entire/cli/auth/repo_token.go:68 — "...set ENTIRE_AUTH_BASE_URL to a core that exposes /oauth/token"
- cmd/git-remote-entire/main.go:247 — "is not a trusted core for cluster"
Both fixed and committed (f9c7d97387).
repo_token.go— "...set ENTIRE_AUTH_BASE_URL to a login server that exposes /oauth/token"git-remote-entire/main.go— "is not a trusted login server for cluster..." (+ updatedmain_test.goassertion)
Lint clean, both packages' tests pass. Left the two nearby code comments that still say "trusted core" — not user-facing. Branch is rebased on origin/main and ready; not pushed.