Address follow-up review on --all-refs

main

Commit

Soph4mo ago
  1. bootstrap.go's batched-mode phase log said "pushing tags" even when the tail batch contained only RefKindOther refs. tailPhaseLabel picks "pushing tags", "pushing other refs", or "pushing tags and other refs" based on the actual contents.

  2. The runReplicate gate change (relayPlans → pushPlans) affects all replicate flows, not just AllRefs. Add a non-AllRefs delete-only replicate test that pre-fix would have silently no-op'd on prune, pinning the broader behavior.

  3. bootstrapWithInputs now recounts Pushed by walking the rewritten plan slice (mirroring finalizeCounts) instead of subtracting warned from bResult.Pushed. The arithmetic relied on bResult.Pushed having already counted rejected refs, which was true but implicit. The new loop makes the relationship with applyRejections explicit and resists future drift.

  4. Comment on allRefsFlag noting it's not idempotent — calling it twice on one command would stack PreRunE hooks. Not a current bug; a one-line guard for future readers.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com Entire-Checkpoint: 5e3f6446f73c

Checkpoints

does git-sync handle any ref or just branches

Claude CodeOpus 4.7[1m]
View session
Checkpoint 1