can you review the faq changes in this branch, can you look at them as an engineer being familiar with general usage of git and how repositories work

Codex·GPT-5.4·Soph·4mo ago·27min·1 Checkpoint·1 file change·+8/-5·73.7K tokens

can you review the faq changes in this branch, can you look at them as an engineer being familiar with general usage of git and how repositories work

4mo ago·4.0s

I’m reviewing the FAQ changes in this branch with a code-review lens, focusing on technical correctness against how Git and repositories actually work. First I’m locating the changed files and reading the diff and surrounding context.

I found the FAQ in README.md; next I’m reading the actual edits and comparing them to the base branch so I can review the content, not just the last commit.

I’ve confirmed the branch is only touching README.md. Now I’m diffing it against main and then checking the implementation/docs for any technical inaccuracies in the new FAQ answers.

I’m checking a few claims that look easy to overstate in Git terms, especially “complete history” and “atomic.” Those are the places docs usually drift from what the implementation and Git servers actually guarantee.

The main concrete problem I’ve found is the atomicity answer: the implementation does not request Git’s atomic push capability, so a multi-ref push can succeed for some refs and fail for others. I’m verifying whether there are any other factual mismatches of that kind before I wrap up.

  1. High: README.md overstates atomicity. The answer says “A single target receive-pack push is atomic in the normal Git sense,” but the implementation never negotiates Git’s atomic push capability; it only sets sideband, report-status, and delete-refs when needed (internal/gitproto/push.go). In Git terms that means a multi-ref push can partially succeed: some refs may update and others may be rejected, with report-status merely reporting that afterward (internal/gitproto/push.go). I’d reword this to say the tool pre-validates unsafe updates, but target-side partial success is still possible within a single push.

  2. Low: the new SSH answer in README.md says “smart HTTP/HTTPS only,” which is technically consistent with the codebase, but it now conflicts with existing docs that still say “HTTPS-only” (docs/protocol.md) while also elsewhere calling the transport “smart-HTTP-only” (docs/protocol.md). Since this FAQ will become the fast path users read first, I’d align those docs in the same branch to avoid transport confusion.

I didn’t find other obvious Git-semantics problems in the FAQ. The rest reads broadly consistent with how refs, reachable objects, one-way sync, prune, and relay/materialized paths work here.

ok, let's remove atomic from the README.md and then maybe remove the faq item?

4mo ago·6.8s

I’m removing the atomicity FAQ entry entirely rather than softening it, since the current answer is the misleading part and the rest of the FAQ stands on its own. After the edit I’ll show the resulting diff.

The FAQ entry is out. I’m checking the diff now to confirm only that section changed.

I removed the atomicity FAQ item from README.md. The diff is limited to deleting that question and answer; no other FAQ content changed.